Update to latest PY

Huw,/Jon,

Ok, Changed the File name to remove spaces… that had no effect.

Then changed the file to similar to what yu suggested yesterday as below:-
; This is specific to GHYC PY and based on a file created by
;
; Class Name Last Published Number
PY Topaz Uno Plus 1255
PY Topaz Race 1168
PY Topaz Race Plus 1172

And now the Log file shows 3 rating loaded, and Sailwave uses them if i try to manually select the correct Class.

So something in the first rows and most of them are empty is what Sailwave doesn’t appear to like???

To there is a workable solution but it is certainly quirky… and it would be nice to find out the reason…

JohnW

Hi John,

Good to hear you can get your file read in by Sailwave.

I have spent several hours on this and I am no closer to solving the problem.

I have established that if I delete the first two lines, i.e. the ones you added, the rest of the file will be read by Sailwave. The log file shows three ratings loaded.

I have looked at your file with octal dump tool to see if their were unexpected hidden characters and their are none.

So at the moment I am stumped.
Kind regards,
Huw

Huw,

I really appreciate all your efforts.

Hopefully there will be a beam of light and the eureka moment.

Thanks.

JohnW

Huw/Jon,

I am still paying around with things here and i noticed something interesting/strange.

Here you have two consecutive Log book dumps, the first is when i loaded up a Ratings file tha we know does not work and please note that according to the first part of the logbook there were 287 ratings loaded, when i loaded up Sailwave, then when i tried to Score the competitors with the "bad Ratings file, it reloads the Rating file but this time only 284 entries loaded.

what follows is the logbook after this attempt. ***** used to identify important lines

16:41:05 CmdLineFile=
16:41:05 CmdLineOpenProforma=0
16:41:05 CmdLineOpenNew=0
16:41:05 CmdLineShear=0
16:41:05 CmdRunFromRoot=0
16:41:05 ScreenWidth=1920
16:41:05 ScreenHeight=1080
16:41:05 WindowsVersion=6.2.9200
16:41:05 WindowsUser=EJW
16:41:05 SailwaveVersion=2.28.2
16:41:05 InstalledOn=04/08/20 12:56:45
16:41:05 InstalledBy=EJW
16:41:05 ProgramFolder=C:\Program Files (x86)\Sailwave
16:41:05 StartInFolder=\Mac\Home\Documents
16:41:05 TempFileFolder=C:\Users\EJW\AppData\Local\Temp
16:41:05 MyDocsFolder=\Mac\Home\Documents
16:41:05 CommonDocsFolder=C:\Users\Public\Documents\Sailwave
16:41:05 CommandLine=
16:41:05 Loading ratings from C:\Users\EJW\Dropbox\GHYC Committee Team Folder\2020 - 2021
GHYC MAIN COMMITTEE\Sailing Secretary\Race Officer\Sailwave\Ratings\2020 PY
*****16:41:05 Loaded 287 ratings
16:41:16 Loaded 10 templates from C:\Users\EJW\Dropbox\GHYC Committee Team Folder\2020 -
2021 GHYC MAIN COMMITTEE\Sailing Secretary\Race Officer\Sailwave\Templates
16:41:16 Loaded 0 templates from C:\Program Files (x86)\Sailwave\templates
16:41:49 Loading ratings from C:\Users\EJW\Dropbox\GHYC Committee Team Folder\2020 - 2021
GHYC MAIN COMMITTEE\Sailing Secretary\Race Officer\Sailwave\Ratings\2020 PY
*****16:41:49 Loaded 284 ratings
16:41:49 Scoring error - Cannot find rating value for PY/TOPAZ UNO PLUS in rating files
16:44:21 Loaded 10 templates from C:\Users\EJW\Dropbox\GHYC Committee Team Folder\2020 -
2021 GHYC MAIN COMMITTEE\Sailing Secretary\Race Officer\Sailwave\Templates
16:44:21 Loaded 0 templates from C:\Program Files (x86)\Sailwave\templates

Having stopped Sailwave and changed the Rating folder file to the "working " file i did the same test again, please note the difference, this time there were 287 ratings loaded on both occasions.

This is the Logbook after the second attempt ***** used to identify important lines

16:50:26 CmdLineFile=
16:50:26 CmdLineOpenProforma=0
16:50:26 CmdLineOpenNew=0
16:50:26 CmdLineShear=0
16:50:26 CmdRunFromRoot=0
16:50:26 ScreenWidth=1920
16:50:26 ScreenHeight=1080
16:50:26 WindowsVersion=6.2.9200
16:50:26 WindowsUser=EJW
16:50:26 SailwaveVersion=2.28.2
16:50:26 InstalledOn=04/08/20 12:56:45
16:50:26 InstalledBy=EJW
16:50:26 ProgramFolder=C:\Program Files (x86)\Sailwave
16:50:26 StartInFolder=\Mac\Home\Documents
16:50:26 TempFileFolder=C:\Users\EJW\AppData\Local\Temp
16:50:26 MyDocsFolder=\Mac\Home\Documents
16:50:26 CommonDocsFolder=C:\Users\Public\Documents\Sailwave
16:50:26 CommandLine=
16:50:26 Loading ratings from C:\Users\EJW\Dropbox\GHYC Committee Team Folder\2020 - 2021
GHYC MAIN COMMITTEE\Sailing Secretary\Race Officer\Sailwave\Ratings\2020 PY
*****16:50:26 Loaded 287 ratings
16:50:38 Loaded 10 templates from C:\Users\EJW\Dropbox\GHYC Committee Team Folder\2020 -
2021 GHYC MAIN COMMITTEE\Sailing Secretary\Race Officer\Sailwave\Templates
16:50:38 Loaded 0 templates from C:\Program Files (x86)\Sailwave\templates
16:51:07 Loading ratings from C:\Users\EJW\Dropbox\GHYC Committee Team Folder\2020 - 2021
GHYC MAIN COMMITTEE\Sailing Secretary\Race Officer\Sailwave\Ratings\2020 PY
*****16:51:07 Loaded 287 ratings
16:51:07 Invalid Yes/No=
16:51:07 Invalid Yes/No=
16:51:07 Invalid Yes/No=
16:51:07 Invalid Yes/No=
16:51:07 Invalid Yes/No=
16:51:07 Invalid Yes/No=
16:51:07 Invalid Yes/No=
16:51:07 Invalid Yes/No=
16:51:07 Invalid Yes/No=
16:51:07 Invalid Yes/No=
16:51:07 Invalid Yes/No=
16:51:07 Invalid Yes/No=
16:51:07 Invalid Yes/No=

Removed repeating lines
16:51:07 Invalid Yes/No=
16:51:07 Invalid Yes/No=
16:51:07 Invalid Yes/No=
16:51:07 Invalid Yes/No=
16:51:07 Invalid Yes/No=
16:51:07 Scoring time is 0.01s
16:51:07 Scoring bottleneck is ResolveTies (100%)
16:51:07 Deformat elapsed cache size/hits=0/0

JohnW

Both,

Ok, I did some further digging around and found out more and hopefully interesting information, which is based on the last information i found and reported above, which is that the 1st time Sailwave reads the Rating files it appears to find all three files and reads the classes and PY successfully, and i tried another test to prove that as follows:-

1, Load Sailwave but do not load any series. check Log Book and 287 ratings have been loaded, and the “Bad” file is now within the ratings folder.
2. Create a new series, and enter a single boat, with a class that is contained in the 3rd and “bad” file, but before entering the craft check the dropdown list of craft already loaded up in the rating files, and sure enough one of the classes that is only in the “bad” file is listed with the correct PY. accept the entry and Sailwave loads up with the PY.
3. Go back and check the log book and Sailwave has still only attempted to read the Ratings files once and the count is still 287.
4. Score this new series… all fine no errors
5. Recheck Logbook to see if Sailwave has now reloaded the Ratings, and it has not.
6. So all seems to work fine if you are creating a new series,

Now i did the same test with an existing series, excluding trying to add a new craft into the series and Sailwave now reloads the Ratings files when you try to Score an existing series and now only loads up 284 Rating entries.

So why is this???

JohnW

Hi John,
Thanks for your reports - I’m looking into it currently - It reads the multiple files when it starts and so you have as many files as you like but there appears to be an issue when the tick box is checked it rereads all the files but only seems to read the 1st - I’m investigating but as my Laptop was replaced under warranty Although I have backups, I have to reinstall all the development environment again and get it configured correctly

Jon

Jon,

Sorry to hear that… let me know if i can provide further info on this one.

JohnW

Hi John,
I’ve looked again at this and its not an issue with Sailwave, it is an issue with your file

If you open it in Excel and look at line 8 this is a very long line with Line Breaks in it

If you delete this line it works fine. I have made some adjustments to the log file in the next version of Sailwave so it shows the name of the ratings files that it is reading and also then the total number of ratings it has read after each file so you can see how many ratings are being read for which file.

Jon,

I am sorry to have to throw a spanner in the works but :-

  1. The line beginning with RYA is also in the standard RYAPN- Limited -data file and that works.
  2. The logic does not explain why all files are read and all rating loaded the 1st time that Sailwave loads.

Good news about the enhancements to the Log file during Ratings load process.

thx

JohnW

Hi John,

Your file does not read correctly the first time on all the attempts I’ve made.

and the line in your file was not exactly formatted the same as the other file, although I agree it looks similar.

The proof is that if you remove it - it works fine. It is not in my code that it is rejected, it is in the OS/Clarion that throws it out.

The line is not to the specification of the Ratings file as per the Sailwave website. In my tests, it consistently fails and as the line is not needed, I suggest the best solution is to remove it or format the data to be simpler if you really want it there but there is no need for it to be there, it only slows down the application and uses disk space…

Regards

Jon

Jon,

Yes Ok, sorted thank you for your efforts.

JohnW